What you craft is up to you (obviously) but if you're looking for crafting, I'd suggest classes that high INT and have feats for it, like Wizard and Alchemist (wizards get Scribe Scroll, and Alchemist's get Brew Potion). Wizard's have the better spell selection for wondrous items, wands, and staves.
The best are Int-based casters (to easily have good spellcraft), prepared casters (to switch the spells you have available to use as prereqs), those with a good spell list and those with bonus feats so picking up crafting feats is less painful; a familiar with the valet archetype speeds things up too. i.e. Wizards rule.
Which is not to say that others are incapable. If you're allowed to take 10 on the roll (RAW, but I've had a GM who was offended by this) then the DCs really aren't hard even if you have to take +5 for skipping one of the prereqs.
If you haven't done this before I'd pick one feat (probably Craft Wondrous Item) and no more to start with. Find out whether it's something you like doing and whether it incites the GM, and if the answers to those are bad you're only down one feat.
Staves are CL11 for the feat. It will be a while for them.
Wands are CL5. Wondrous is CL3. Arms & Armor is 5th.
Any spell caster should be OK. [Alchemy is wonky with respect to crafting. It may or may not work, depending on GM.] Spontaneous casters will have difficulty providing spells for potions/scrolls/wands. Divine Prepared casters (cleric, druid) get the whole list while Arcane Prepared have to learn it.
I have been told that witches have a very wand friendly list.
Even if your list does not match what you want to make, you can supply the spell via other ways (like a hired caster or other party member).
Go first for Craft Wondrous Items, as it not only is low level, it also is very versatile for the whole party. Many of the magic items you have as a 20th level character will be Wondrous.
Wizards and Witches are squishy. Divine casters and lesser arcane casters (4th level or 6th level max) are less so. Divine casters generally use armor. Some arcane casters can as well.
Crafting should not be the main focus, but a secondary focus for the caster. Pick your main focus and tack on crafting.
/cevah