|
I know you have not been working on this for awhile. Is there any chance of putting the new APG sorsorer blooklines in the next edition?
I guess the other question is what else will be new in this edition.
Glad you are back. This is my preferred character sheet and I am really looking forward to all the APG content being added to the sheet.
Thanks for all the work you have done and all the work you will do on this sheet.
I'm currently doing the data entry while Erian does the code-crunching.
I've input all of the alternate racial traits.
I've input all of the alternate racial favored class bonuses, though Erian has to do some serious thinkipating for how to make them work. (The fighter's ability to add +1 to the CMD against two maneuvers turns into a huge list of combinatorial abilities, for instance).
I've input all of the archetypes for Barbarians, Bards, Fighters and Rangers
So, yes, the extra bloodlines will be put in. I imagine they will be fairly straightforward once Erian gives me the template to work within.
I do not know when Erian will be finished with his part, but I'm doing this in bits and pieces as I go along with something else that requires me to be present, but not really thinking.
Yep, we're cruising right along on these. I'm thinking v.0.9.3 will include the alternate racial stuff, then v.0.9.4 will include the alternate class stuff. The bloodlines, however, are very easy to add as they exist in their own little structure. If there's one particular bloodline you want, I could use it as the test run for adding these since I've cleaned up my approach to data tables.
Awesome. Yes, I am hoping to get the Shadow bloodline.
I have a rogue/sorcerer/shadowdancer and since the APG I want to use the shadow bloodline.
Thanks
Okay, no problem. I don't see much I'm going to have to change in the bloodline data structure, but adding the Shadow info will be a good test anyway...
Hello Erian - I am wondering what to do if I choose a feat like extra hex?
If the structure for this has not been implemented yet that is cool.
I suppose the best place to put an "extra" drop down is in the FEAT SETTINGS box.
Many thanks to you and AAG for the hard work you are doing.
For the nujmerous "Extra" feats I generally build in three levels--e.g. Extra Rage I, Extra Rage II, and Extra Rage III--with the higher levels requiring the lower. As these are selected, I build in automation to update the appropriate class ability, etc. I haven't built in the Extra feats from the APG as yet--those will be coming once I get the alternate race and class material in place.
For the nujmerous "Extra" feats I generally build in three levels--e.g. Extra Rage I, Extra Rage II, and Extra Rage III--with the higher levels requiring the lower. As these are selected, I build in automation to update the appropriate class ability, etc. I haven't built in the Extra feats from the APG as yet--those will be coming once I get the alternate race and class material in place.
Cool thanks
For the nujmerous "Extra" feats I generally build in three levels--e.g. Extra Rage I, Extra Rage II, and Extra Rage III--with the higher levels requiring the lower. As these are selected, I build in automation to update the appropriate class ability, etc. I haven't built in the Extra feats from the APG as yet--those will be coming once I get the alternate race and class material in place.I've noticed a bug with the "Extra" feats:
If you buy Extra Stuff I, and it's followed in your list of feats by, for example, Improved Initiative, it gets recorded as "...Extra Stuff IImproved Initiative...", which gets read as Extra Stuff II, and gives you credit for having it twice...
Thats interesting because when you take extra hex twice - it only notes one extra hex on the feats and abilities page.
|
|
Erian,
Your sheet is my preferred sheet but when you were gone taking care of business I was looking for another option.
Have you checked out Ogre's sheet. I like what he did with the spell sheet and there are a few other things I like about it.
As my current character progresses he is a rogue4/sorcerer 1/shadowdancer 2 - for thematic and roleplaying reasons he may end up take a level of cleric (you would have to be there...). I think this is going to be complicated on your sheet (although as I write this I may just do another sheet for the one level of cleric and have a separate spell sheet for it. I will consider this more.
When it comes to the Ogre sheet The spells are handled great (but some spells are mssing from the pull down menu). You list the spells you took on one page and the actual spell page not only has the name of the spell but information right on the sheet about the spell.
Right now I print spell cards from the link you have on the sheet and that works and I like the idea of having the important statistics on the actually spell sheet.
There are some things about the other sheet that really are not working for me so I am hoping you are able to finish off the APG stuff and keep up when Ultimate Magic comes out.
Thank you so much for all your hard work on this. I appreciate it very much and it makes character creation so much easier.
Requested:
Figure out a way to auto-calculate the value of armor and weapons other than the material and the base bonus. Things like frost, flaming, holy, glammered, etc do not add it. Currently, I enter a value placeholder in the character equipment area (0 weight, equiped)
Add a calc for the "bashing" quality for shields.
Add ioun stones to the magic item list.
|
Erian, I was working on the Eidolon page of 9_2 and it is unfortunately pretty broken. Looks like the table orders were swapped in mid development, conditions are looking up the wrong values in the various lists, wrong types causing expressions to fail - basically a whole lot of stuff.
Mind you this is using Open Office so maybe Excel is more tolerant of this kind of stuff ...
Ive managed to correct it as well as I can but Im wondering if the new format you are using will make this work irrelevant.
If you would like I can mail you that part of the sheet to see what I have done, but as I have been having to reverse engineer everything it probably isnt pretty :)
Anyways please let me know.
Cheers and keep up the good work!
Nik
...I await the sexy Ranger variant options.
Took a few days more than I thought, but I've got the next version ready for testing. This one implements my new approach to racial traits, and also adds the alternate racial trait functionality. To accommodate the new character modifications, there is now an expanded Race section on the Getting Started tab. I was trying to add in the Favored Class bit as well, but finally gave up in favor of getting something out to everyone. I'll be working on that functionality next, then hit the archetypes (which will require me to rebuild the class abilities like I did the racial traits).
Character Sheet File: PRPG_CS_v_0_9_3.zip
For the nujmerous "Extra" feats I generally build in three levels--e.g. Extra Rage I, Extra Rage II, and Extra Rage III--with the higher levels requiring the lower. As these are selected, I build in automation to update the appropriate class ability, etc. I haven't built in the Extra feats from the APG as yet--those will be coming once I get the alternate race and class material in place.I've noticed a bug with the "Extra" feats:
If you buy Extra Stuff I, and it's followed in your list of feats by, for example, Improved Initiative, it gets recorded as "...Extra Stuff IImproved Initiative...", which gets read as Extra Stuff II, and gives you credit for having it twice...
Hmm, that's an interesting one! It may be that my new approach to data references will fix this--I'll have to think on it a bit!
Erian,
Your sheet is my preferred sheet but when you were gone taking care of business I was looking for another option.
Have you checked out Ogre's sheet. I like what he did with the spell sheet and there are a few other things I like about it.
As my current character progresses he is a rogue4/sorcerer 1/shadowdancer 2 - for thematic and roleplaying reasons he may end up take a level of cleric (you would have to be there...). I think this is going to be complicated on your sheet (although as I write this I may just do another sheet for the one level of cleric and have a separate spell sheet for it. I will consider this more.
When it comes to the Ogre sheet The spells are handled great (but some spells are mssing from the pull down menu). You list the spells you took on one page and the actual spell page not only has the name of the spell but information right on the sheet about the spell.
Right now I print spell cards from the link you have on the sheet and that works and I like the idea of having the important statistics on the actually spell sheet.
There are some things about the other sheet that really are not working for me so I am hoping you are able to finish off the APG stuff and keep up when Ultimate Magic comes out.
Thank you so much for all your hard work on this. I appreciate it very much and it makes character creation so much easier.
Kor's got some good stuff on his sheet, and I do like how he's handling spells over mine thus far. One thing to keep in mind is a lot of the fancy stuff he does is handled through macros, which I purposely keep out of this sheet in order to keep compatibility high. However, I do think I can come to a good spell implementation without macros. I basically took the route of hitting the APG classes before doing spells, then of course got sidetracked by life...
Requested:
Figure out a way to auto-calculate the value of armor and weapons other than the material and the base bonus. Things like frost, flaming, holy, glammered, etc do not add it. Currently, I enter a value placeholder in the character equipment area (0 weight, equiped)
Add a calc for the "bashing" quality for shields.
Add ioun stones to the magic item list.
All definitely on my to-do list!
glad to see the sheet isn't dead. welcome back to the land of the living erian.
Thank you, sir...it's good to be back!
Erian, I was working on the Eidolon page of 9_2 and it is unfortunately pretty broken. Looks like the table orders were swapped in mid development, conditions are looking up the wrong values in the various lists, wrong types causing expressions to fail - basically a whole lot of stuff.
Mind you this is using Open Office so maybe Excel is more tolerant of this kind of stuff ...
Ive managed to correct it as well as I can but Im wondering if the new format you are using will make this work irrelevant.
If you would like I can mail you that part of the sheet to see what I have done, but as I have been having to reverse engineer everything it probably isnt pretty :)
Anyways please let me know.
Cheers and keep up the good work!
Nik
Yes, the eidolon is a tangled mess right now. All of the companions/familiars/etc. aren't really functioning fully the way I'd like. At present I'm thinking the best approach may be a separate sheet for these, specifically because sharing the same data structure for feats with the character is problematic. However, I may be able to fix this with my new approach. Another thing for me to think on a bit...
I've been lurking for a bit and playing with the spreadsheet. I can't seem to find any docs on how to build a custom class. I know someone long ago suggested better docs would be a good thing.
Can someone do a quick post on how to do various common things in the custom class tab (or confirm that you can't)?
I understand excel well enough to add abilities that are text and require that the user remember them such as +2 vs. fire spells or 'immunity to sleep'. The popup example shows how to make fire resistance show up on the character printout. But what about class abilities that change some value elsewhere on the sheet.
For example:
I want the class to give an extra feat at 5th level.
Or at 5th level the class provides Medium Armor proficiency.
At 10th level you get a +2 stealth. (i.e. class bonus to some skill)
At every 3rd level you get an extra spell.
At 6th level you get +1 to perception.
At 10th level +1 to strength or +1 to choice of stat.
Custom classes are the hardest part, specifically because automating the class features can involve bouncing all over the file. For some of the above, you're getting into modifying the Feat tab (build in logic to auto-add the feat at the specified level) and the DataSkills tab (add a formula in the Class column to do the auto-calc). The stat bumps are a bit different, but if you can follow the logic for the Jotun that might help.
I definitely want to get around to documenting this at some point.
...I await the sexy Ranger variant options.No no dont listen to him!
MONKS! Monks is where its at - We need them to protect us from those gosh darn Kender!
Heh, you may both win...I've got a monk and a ranger in my upcoming homegame. Any particular variants of special interest?
|
|
Well I managed to get Monks of the Open hand (sic) to work by replacing the class abilities in the ability tables, adding Improvised weapons as a group and putting in the improvised weapons in the weapons table.
Also adjusted the weapon proficiencies, free feats and a few other odds and sods, including reimplementing something that seems to have disappeared between versions although it is calculated, just no longer displayed - Weapon proficencies ... I put them at the end of the Class abilities block.
This 'hard codes' the monk to be only of that type unfortunately but I suppose if there was going to be a long delay between versions it would do.
So basically give Shifty his Ranger (just hard code all his animal companions to be small pink lizards called Barney :) )
Well the 'bad man' above is the GM for the game my Ranger is in, and I'm the GM for his Monk... so its mutually assured desrtuction.
I was going down the path of Ranger (Beastmaster), wasn't taking any racial (Elven) variants.
:)
I just tried building a straight no frills Half-elven Bard and got error: 508 for the class abilities.
I can try and debug it for you, or will you rather I leave it for further bugs ?
Hmm, no do check that out further if you can. I haven't changed anything in particular with the core classes yet, so the Bard should work as it did before. Now, that assumes of course I didn't break something inadvertently, and that's often a big assumption!
RPG Superstar 2014 Top 16
|
Took a few days more than I thought, but I've got the next version ready for testing. This one implements my new approach to racial traits, and also adds the alternate racial trait functionality. To accommodate the new character modifications, there is now an expanded Race section on the Getting Started tab. I was trying to add in the Favored Class bit as well, but finally gave up in favor of getting something out to everyone. I'll be working on that functionality next, then hit the archetypes (which will require me to rebuild the class abilities like I did the racial traits).
Character Sheet File: PRPG_CS_v_0_9_3.zip
I can't wait to see the next version, hopefully it will have the Alternate class abilities, yes? For now I'm making a custom class, the Drunken Barbarian, to fulfill my requirements. Thanks so much for working on this, it's impressive!
I am still plugging away at the Alternate class abilities. There are a lot of them, and they each need checking.
Erian, I'd like to propose a drop down be added to the Getting Started tab that says "PFS Legal".
This will require flagging each feat and trait with a TRUE/FALSE column and populating one of your dynamic drop downs appropriately.
I can't wait to see the next version, hopefully it will have the Alternate class abilities, yes? For now I'm making a custom class, the Drunken Barbarian, to fulfill my requirements. Thanks so much for working on this, it's impressive!
I'm going to hit the alternate favored class piece first, then look to tackle the archetypes in chunks. This will give AAG time to get more of the data entry done as well. At present, I'm building my "do these first" list based on feedback from you folks here...
I am still plugging away at the Alternate class abilities. There are a lot of them, and they each need checking.
Erian, I'd like to propose a drop down be added to the Getting Started tab that says "PFS Legal".
This will require flagging each feat and trait with a TRUE/FALSE column and populating one of your dynamic drop downs appropriately.
Yep, the PFS functionality has been on my mind as well, mostly as I've been playing with Herolab and like how they flag things. In my rebuild world I've got a slightly different approach to the selectors for what will be allowed in the sheet, and the PFS switch is on that list.
I did notice one small error: When I chose Barbarian as first level and then Alchemist as levels 2 and 3, for some reason it wants me to choose a level 2 feat, when I should only be choosing feats for levels 1 and 3. Any idea why this would happen?
That's actually just a copy/paste error on my part when I was cleaning up the data in the sheet before posting. You can copy one of the black blocks (like the one on 4th level) over that block for 2nd level and be good to go.
|
RPG Superstar 2014 Top 16
|
That's actually just a copy/paste error on my part when I was cleaning up the data in the sheet before posting. You can copy one of the black blocks (like the one on 4th level) over that block for 2nd level and be good to go.
I did notice one small error: When I chose Barbarian as first level and then Alchemist as levels 2 and 3, for some reason it wants me to choose a level 2 feat, when I should only be choosing feats for levels 1 and 3. Any idea why this would happen?
Excellent! I must say, I'm extremely happy to find someone who has made a well-thought out Excel sheet without using macros. Again, very impressed. Thanks!
|
|
I noticed a Portrait/Landscape error a while back, but forgot to mention it. I got used to just changing it after I downloaded the sheet. I know I am one of those stuck in my ways using portrait, thought I do like the setup of the landscape. I just can't switch!
On the P-Back page, on the "Armor/Weapons Wgt area under the equipment, it has the following...
='L-Front'!F81+'L-Front'!F94+'L-Front'!F107+'L-Front'!AS103+'P-Back'!CG8+'P -Back'!CE18
I just change all the L's to P's, then everything calculates right for the weapons, but I thought I would bring it up.
Well, it occurred to me I really need to take care of the various items y'all have reported before I start diving into lengthy changes/updates. So, to that end I have now fixed the Extra... feats so they won't conflict with "I" feats. Specifically, you now use the pipe character--|, ||, and |||-- for these rather than I, II, and III. That way the program sees it as a distinct character. It might be tricky at first for folks that type the names rather than select from the menu, so I'm adding a note as well.
Secondly, I've implemented all of the Extra... feats from the APG so they'll now work for you guys needing things like Extra Hex.
I'll be hitting other bug fixes and requests as I continue working on the favored class functionality.
Excellent! I must say, I'm extremely happy to find someone who has made a well-thought out Excel sheet without using macros. Again, very impressed. Thanks!That's actually just a copy/paste error on my part when I was cleaning up the data in the sheet before posting. You can copy one of the black blocks (like the one on 4th level) over that block for 2nd level and be good to go.
I did notice one small error: When I chose Barbarian as first level and then Alchemist as levels 2 and 3, for some reason it wants me to choose a level 2 feat, when I should only be choosing feats for levels 1 and 3. Any idea why this would happen?
Thanks back for using the sheet! It's been a fun challenge coming up with the best solution to make the sheet work well without macros. I really want to rebuild the sheet from the ground up at some point in order to ensure it's clean and using my "best practices" approach to everything. I know I've got to balance that desire with getting regular updates out for folks to use, though...
I noticed a Portrait/Landscape error a while back, but forgot to mention it. I got used to just changing it after I downloaded the sheet. I know I am one of those stuck in my ways using portrait, thought I do like the setup of the landscape. I just can't switch!
On the P-Back page, on the "Armor/Weapons Wgt area under the equipment, it has the following...
='L-Front'!F81+'L-Front'!F94+'L-Front'!F107+'L-Front'!AS103+'P-Back'!CG8+'P -Back'!CE18
I just change all the L's to P's, then everything calculates right for the weapons, but I thought I would bring it up.
Thanks for the heads-up...fixed it for the next release!
If you are ever in Sydney e7 let me know and I will buy you beer or preferred beverage.
If you are ever in Sydney e7 let me know and I will buy you beer or preferred beverage.
Sydney is a "must see" on my list of travel sites, so hopefully one day! I like nice, malty dark brews myself--hints of chocolate and/or coffee are nice!
Not sure if it's me missing a setting or what, but under "spells and effects" the sheet will not let me choose a mutagen and Barbarian Rage at the same time. Any clue why? From my reading of the rules they shouldn't be mutually exclusive.
That's some incomplete functionality--I've only built the first drop-down to hold the rage and mutagen titles. You can actually just copy that drop-down and paste it in the next block, then you can select both at the same time.
|
RPG Superstar 2014 Top 16
|
Not sure if it's me missing a setting or what, but under "spells and effects" the sheet will not let me choose a mutagen and Barbarian Rage at the same time. Any clue why? From my reading of the rules they shouldn't be mutually exclusive.That's some incomplete functionality--I've only built the first drop-down to hold the rage and mutagen titles. You can actually just copy that drop-down and paste it in the next block, then you can select both at the same time.
Man, it's so much easier to fix little problems like that when 1) you don't use macros, and 2) you don't lock the damn thing from editing like EVERYONE seems to do when they make these. I can appreciate that people don't want their work stolen, but it's SO MUCH BETTER when you let it be editable by end-users. Thank you again for this!!
I've sent the alternate Bard and Barbarian class data in and am awaiting feedback from Erian before doing the rest.
In some cases (Arcane Duellist, for example), there are things that are normally 'level step integrations' which get replaced with specific feats by level, and I want to make sure I'm putting them in in the order that Erian wants before doing this for about 200 class+archetype combos.
Quick update...I actually have the racial favored classes fully functioning for selection and display of the benefits (they'll appear both in the "Race" section on the Getting Started tab and on the Abilities & Feats tab in the "Class Abilities" section. I've still got to automate some of the second level selections (e.g. the energy resistance type for a gnome druid or the weapon selections for an elf ranger). Once I've got that piece done, I've got to do the internal automation to get the favored class benefit properly affecting relevant non-conditional items (e.g. automatically adding to the bombs/day for a gnome alchemist or the rnds/day of rage for a half-orc barbarian). I think I'll be able to complete these by tomorrow, but if not I'll have to shift into next week since I've got my first home game in quite a while scheduled for tomorrow. If this is the case, I'll go ahead and send out the non-automated version so you all can see my approach and comment (plus it contains all the fixes for recently reported problems).
Man, it's so much easier to fix little problems like that when 1) you don't use macros, and 2) you don't lock the damn thing from editing like EVERYONE seems to do when they make these. I can appreciate that people don't want their work stolen, but it's SO MUCH BETTER when you let it be editable by end-users. Thank you again for this!!
Heh, you hit on yet another of my design goals--keep this thing as customizable as possible by other users...Now, the complexity of the tables/formulas has grown much greater than I like, and that's actually one of the things behind my thinking on simplification. Needless to say, I don't look to change this design goal any time soon (much to the disappointment of some potential users...).
I've sent the alternate Bard and Barbarian class data in and am awaiting feedback from Erian before doing the rest.
In some cases (Arcane Duellist, for example), there are things that are normally 'level step integrations' which get replaced with specific feats by level, and I want to make sure I'm putting them in in the order that Erian wants before doing this for about 200 class+archetype combos.
Can you resend that link--I had my chat archives turned off and so now I can't find the darn thing!
I just began playing with the sheet, I wonder how hard it would be to add a gestalt component. I know it isn't really pathfinder, but I don't often have a full complement of players when we play and we often end up with gestalt characters for survivability.
Gestalt support has been requested a few times. Unfortunately, it's actually very complex to implement properly. Now, the data table rebuild I'm looking to do for the class abilities could actually help to reach this goal. Taking the new race design as an example, I now simply list the racial traits in a single cell, then reference that cell to build a list of racial traits from the common centralized list. I'm going to do the same for class abilities, so theoretically you could build a custom class that just selects from the common class abilities. There is a little more complexity, however, in that the race approach doesn't have to worry with character level for when racial traits appear, while in classes this is an obvious need. I'm still thinking on the best way to smack this around...
|
|
i ran into an error while making a dragon disciple on v9.3. i've got an 11th lvl character. 5 sorcerer/6 dragon disciple. when i get to the 4th lvl of dragon disciple on the sheet, it errors on the "abilities and feats tab". the "class abilities" errors and says #NAME?. it works fine up to the point when the character hits 9th lvl and becomes 5 sorcerer/4 dragon disciple.
|
Great sheet, though quick not that Weapon Focus doesn't seem to work, displays the ones without weapons selected on the abilities/feat tabs and if you select a weapon that line goes away, leaving any remaining unselected on the sheet. Nor does it seem to add the +1 to attack on the front tabs weapon and attacks area.
Great sheet, though quick not that Weapon Focus doesn't seem to work, displays the ones without weapons selected on the abilities/feat tabs and if you select a weapon that line goes away, leaving any remaining unselected on the sheet. Nor does it seem to add the +1 to attack on the front tabs weapon and attacks area.
On the display on the front side, did you make sure that the type of output sheet you selected on Getting Started was the one you used?
EG, if it's still set to Landscape and you're using Portrait, it's going to not show up on portrait.
I cannot replicate your problem with the line 'going away'. Erian, can you look into that one?
|
|
Hi Erian
More on the Err:508 Im getting (in Open Office)
Class_Abilities_Summary is returning Err:508
I traced it back to cell F1 of the Class Abilities sheet.
In that cell it builds up all the class abilities from all the individual class summaries.
Through a process of elimination of the various IF constructs I was able to make the error occur ONLY when the Dragon Disciple class abilities summary was added - EVEN if it should be empty (ie the character isn't a Dragon Disciple).
So going down the class abilities sheet I found that a number of the Dragon disciples cells were showing Err:508
The source of this error is occurring in the Bloodlines Sheet.
More so I am seeing this error for Elemental, Infernal and Undead Blood lines as well in the Bloodlines sheet.
Now in Open Office Err: 508 means
Pair missing
For example, closing parenthesis without opening parenthesis or missing closing parenthesis in the middle of the formula (missing closing parenthesis at the end of a formula is added automatically).
My notes added here: It can also mean that a function is malformed, ie Open office uses ; for parameter separators while Excel uses ,
For example Excel function looks like
IF(A, B, C)
while Open Office Function looks like
IF(A; B; C)
But Ive checked this and it seems ok.
In doing further research (and you are going to hate this part) I found that some excel written sheets that reference cells by sheetname!cellname don't get converted correctly (Open Office uses sheetname.cellname) similarly some functions can not get converted (see above)
So what could also be happening here is if you are constructing a statement in your sheet you may have inadvertently hard coded something that breaks in Open Office.
In other words what may be happening here is a "simple" compatibility issue between the 2 spreadsheets.
I'll hand it over to you at this point for feed back, but Ill keep on looking. The problem is repeatable, has only started in 9_3 and relates to the Bloodlines, on a sheet run on Open office.
If anyone else out there has this same problem?
If so just let me know and on which spread sheet. If you are running Open office let me know as well if you DONT get the problem (maybe its just my environment)
To duplicate it, build a 3rd level bard Half elven as you normally would. Once you have done all the getting started go to the Abilities&Feats sheet (either L or P - I check both)
cheers all and sorry about the mega post.
Nik
|
|
Hi Erian
Error 508: an update.
In order to test the hypothesis that it is a compatibility problem I asked a fellow user of your spreadsheet to run it under Excel (for Windows 7)
Result :
Works fine.
So anyone out there seeing this problem? On Open Office on XP.
Are there other users of Open Office that DONT see this problem?
Still searching.
Once again my apologies if the geek speak offends anyone here.
Nik
Hi Erian
Error 508: an update.
In order to test the hypothesis that it is a compatibility problem I asked a fellow user of your spreadsheet to run it under Excel (for Windows 7)
Result :
Works fine.
So anyone out there seeing this problem? On Open Office on XP.
Are there other users of Open Office that DONT see this problem?Still searching.
Once again my apologies if the geek speak offends anyone here.
Nik
i am having the same problem with it i have looked at the code there are no errors in it compared to 9.1 it just is not working