Do you think that this trait should be against all humanoids or one sub type?

[Zautos']

Scarred by Space Pirates

You were attacked by space pirates in your youth, inspiring you to find ways to deal with the alien interlopers should they return.

Benefit(s) You gain a +1 trait bonus on attack rolls against humanoids.

Right now it gives +1 to hit against all humanoids. So humans, elves gnomes and so one.

or do you think it should be against one subtype? like human or elf.

[graystone]

Seems fine. Ancestral Weapon gets you a masterwork melee weapon made silver or cold iron up to 500 gp and a +1 trait bonus on attack rolls with weapons made of the selected material. Personally Scarred by Space Pirates seems weaker as Ancestral Weapon get you a +1 from masterwork and another from the trait bonus.

[Zautos']

Did not think of that.

Also, thank you I forgot the name of that trait.

[hollyfrosty]

I don't know why this thread got moved to homebrew (apparently a mod didn't recognize the trait), but it is supposed to be against specific subtypes, but I guess they're ones that d20pfsrd can't mention? (Which is weird because d20pfsrd has full pages for some of them, but I don't really know how the OGL works.)

The full text (from Archives of Nethys, because I don't own People of the Stars, but I'm assuming it's accurate):

Scarred by Space Pirates wrote:

You were attacked by Vercite space pirates in your youth, inspiring you to find ways to deal with the alien interlopers should they return. You gain a +1 trait bonus on attack rolls against humanoids from beyond Golarion, including androids, kasathas, Triaxians, and Vercites, among others.

[The Sideromancer]

hollyfrosty wrote:

I don't know why this thread got moved to homebrew (apparently a mod didn't recognize the trait), but it is supposed to be against specific subtypes, but I guess they're ones that d20pfsrd can't mention? (Which is weird because d20pfsrd has full pages for some of them, but I don't really know how the OGL works.)

The full text (from Archives of Nethys, because I don't own People of the Stars, but I'm assuming it's accurate):

Scarred by Space Pirates wrote:

You were attacked by Vercite space pirates in your youth, inspiring you to find ways to deal with the alien interlopers should they return. You gain a +1 trait bonus on attack rolls against humanoids from beyond Golarion, including androids, kasathas, Triaxians, and Vercites, among others.

So now we can argue whether it applies to elves.

[Zautos']

The Sideromancer wrote:

hollyfrosty wrote:

I don't know why this thread got moved to homebrew (apparently a mod didn't recognize the trait), but it is supposed to be against specific subtypes, but I guess they're ones that d20pfsrd can't mention? (Which is weird because d20pfsrd has full pages for some of them, but I don't really know how the OGL works.)

The full text (from Archives of Nethys, because I don't own People of the Stars, but I'm assuming it's accurate):

Scarred by Space Pirates wrote:

You were attacked by Vercite space pirates in your youth, inspiring you to find ways to deal with the alien interlopers should they return. You gain a +1 trait bonus on attack rolls against humanoids from beyond Golarion, including androids, kasathas, Triaxians, and Vercites, among others.

So now we can argue whether it applies to elves.

i think they would have mentioned elfs if it worked on them as well